Closed AmyOctoCat closed 1 day ago
LGTM! The intention of that was to simply skip those checks, but clearly not working as intended.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.23%. Comparing base (
290938a
) to head (2aa5a4c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the approval @davidorme . It looks like it hadn't fixed it as I'd hoped unfortunately. I think it might still be the issue of the commit being generated by another action unfortunately, which might be a bit harder to work around...
I opened #256 - GH are disabled atm, manual profiling should be done
Description
Attempting to fix the issue of the PR checkers hanging in a 'Waiting' state after approval. Currently the profiling is auto-generating a commit on approval with a commit message that contains [skip actions]. Trying to remove this to see if it fixes the issue, although I am unsure if github will allow a commit generated by an action to trigger further actions. Need approval to see if the fix has worked.
Fixes #241
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
- N/A$ poetry run pytest
- N/AFurther checks