ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
16 stars 6 forks source link

Fixing PR checkers hanging after profiling runs on PR approval #242

Closed AmyOctoCat closed 1 day ago

AmyOctoCat commented 1 month ago

Description

Attempting to fix the issue of the PR checkers hanging in a 'Waiting' state after approval. Currently the profiling is auto-generating a commit on approval with a commit message that contains [skip actions]. Trying to remove this to see if it fixes the issue, although I am unsure if github will allow a commit generated by an action to trigger further actions. Need approval to see if the fix has worked.

Fixes #241

Type of change

Key checklist

Further checks

davidorme commented 1 month ago

LGTM! The intention of that was to simply skip those checks, but clearly not working as intended.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.23%. Comparing base (290938a) to head (2aa5a4c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #242 +/- ## ======================================== Coverage 95.23% 95.23% ======================================== Files 28 28 Lines 1701 1701 ======================================== Hits 1620 1620 Misses 81 81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AmyOctoCat commented 1 month ago

Thanks for the approval @davidorme . It looks like it hadn't fixed it as I'd hoped unfortunately. I think it might still be the issue of the commit being generated by another action unfortunately, which might be a bit harder to work around...

MarionBWeinzierl commented 2 weeks ago

I opened #256 - GH are disabled atm, manual profiling should be done