ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
23 stars 9 forks source link

Problem with `numpy` and NetCDF #257

Closed davidorme closed 3 months ago

davidorme commented 3 months ago

Describe the bug

This issue is to try and reproduce a bug observed in use. @shirleycwj has tried installing pyrealm 1.0.0 and gets the error reported in this thread, which is to do with xarray and numpy:

https://github.com/numpy/numpy/issues/26710

I can't reproduce this on my Mac. At the moment, pyrealm requires numpy 2 but uses an outdated version of xarray. I'm going to raise a PR to update xarray and see if this triggers.

davidorme commented 3 months ago

@Shirleycwj has reported that this goes away with clean venv installs. I'm not sure quite how this happened but the issue occurred on two separate OS (Mac/Windows) - something about the update on pre-existing pyrealm from 0.8.0 to 1.0.0 seems to possible be an issue, but a clean install does not.

davidorme commented 3 months ago

Closing - cannot reproduce and does not occur with clean installation or on runners.