ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Allow PModel to accept an array of kphio values. #261

Closed davidorme closed 1 month ago

davidorme commented 2 months ago

Is your feature request related to a problem? Please describe.

At present, the kphio argument to pyrealm.pmodel.pmodel.PModel is expected to be a float value. If this is supplied, it is converted into a numpy scalar array, with the value then being used for all calculations. However, users might want to be able to supply per-observation estimates of kphio rather than a single global initial value.

Describe the solution you'd like Update kphio to accept scalar or array inputs and then check that array kphio values broadcast correctly across other array inputs.