ImperialCollegeLondon / safedata_validator

Python tools to validate and publish datasets using the safedata metadata format.
https://safedata-validator.readthedocs.io/
MIT License
2 stars 4 forks source link

Update taxon builder tools #115

Closed davidorme closed 4 months ago

davidorme commented 5 months ago

This PR fixes #106

codecov-commenter commented 5 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (177abd5) 78.11% compared to head (80dfec4) 79.06%.

Files Patch % Lines
safedata_validator/taxondb.py 64.81% 19 Missing :warning:
safedata_validator/entry_points.py 92.85% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #115 +/- ## =========================================== + Coverage 78.11% 79.06% +0.95% =========================================== Files 13 13 Lines 3674 3712 +38 =========================================== + Hits 2870 2935 +65 + Misses 804 777 -27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidorme commented 5 months ago

Note that the new tests do actually call on remote resources (GBIF and NCBI) but only for small payloads to validate timestamps. This links into #57, so that when this gets tackled, these tests should also be mockable.