ImperialCollegeLondon / safedata_validator

Python tools to validate and publish datasets using the safedata metadata format.
https://safedata-validator.readthedocs.io/
MIT License
2 stars 4 forks source link

Updating the Zenodo handling #162

Closed davidorme closed 1 week ago

davidorme commented 2 weeks ago

This PR expands a bit of the actual issue described in #161 after feedback from Sam.

Closes #161

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 13.60544% with 127 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (9324649) to head (9e56bf1). Report is 20 commits behind head on develop.

Files Patch % Lines
safedata_validator/zenodo.py 5.51% 120 Missing :warning:
safedata_validator/entry_points.py 65.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #162 +/- ## =========================================== - Coverage 79.04% 77.88% -1.17% =========================================== Files 13 13 Lines 3741 3807 +66 =========================================== + Hits 2957 2965 +8 - Misses 784 842 +58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidorme commented 2 weeks ago

@jacobcook1995 I haven't tested this stuff, but it does it look sensible? Still need to figure out what went wrong with Sam.

davidorme commented 1 week ago

@jacobcook1995 This is changed again with the update to match the changed Zenodo new version process. I think this is a sensible resolution (use md5 and filename to check for new/changed/unchanged/removed files) and I've updated the docs to match.