search

ImperialCollegeLondon / safedata_validator

Python tools to validate and publish datasets using the safedata metadata format.
https://safedata-validator.readthedocs.io/
MIT License
2 stars 4 forks source link

Feature/zenodo workflow fixes #37

Closed davidorme closed 1 year ago

davidorme commented 1 year ago

This PR is mostly tuning safedata_validator to work cleanly with the metadata webserver implementation. There are some documentation updates, some minor tweaks and a rewrite of the safedata_post_metadata entry point to add functionality to update the gazetteer data stored on the webserver.

jacobcook1995 commented 1 year ago

Oh and also does this pull request fix #36? (and also #25?)

davidorme commented 1 year ago

No - doesn't fix either #36 or #25.

jacobcook1995 commented 1 year ago

No - doesn't fix either #36 or #25.

Ahh right (I must admit to not fully grasping #25). Does this not fix #36 because the update_gazetteer function defined in zenodo.py wouldn't get a proper response from the server even if it was run with valid data?

davidorme commented 1 year ago

Does this not fix #36 because the update_gazetteer function defined in zenodo.py wouldn't get a proper response from the server even if it was run with valid data?

No - the issue is that sdv used to get this data from the server (when that was the source of truth) and used a simplified version of the full GeoJSON. But now the server is just a metadata server, admins should be maintaining that GeoJSON resource and using it directly with sdv and pushing updates to the server as required. So sdv should use that full GeoJSON file as the resource.