Fix `mypy` errors and reenable `mypy` as a pre-commit hook

ImperialCollegeLondon / safedata_validator

Python tools to validate and publish datasets using the safedata metadata format.

https://safedata-validator.readthedocs.io/

MIT License

2 stars 4 forks source link

Fix `mypy` errors and reenable `mypy` as a pre-commit hook #51

Closed jacobcook1995 closed 1 year ago

jacobcook1995 commented 1 year ago

We initially setup mypy to be a pre-commit hook. We then turned it off as fixing mypy on a pre-existing project is an absolute nightmare.

However, for 3.0.0 onwards we do want mypy checking enabled, so we are going to have to bite the bullet and fix all the errors. Once this is done, we should reenable mypy as a pre-commit hook to enforce consistent typing going forward.

jacobcook1995 commented 1 year ago

Fixed by #59