ImperialCollegeLondon / safedata_validator

Python tools to validate and publish datasets using the safedata metadata format.
https://safedata-validator.readthedocs.io/
MIT License
2 stars 4 forks source link

Handle metadata for trailing empty fields #61

Closed davidorme closed 1 year ago

davidorme commented 1 year ago

The sdv.field.Dataworksheet class keeps an internal representation of the whole worksheet read from file, which can include trailing blank fields. Those are kept to validate that the rows below are empty but the returned metadata and the reported worksheet size do not remove the empty fields. This PR:

This PR fixes #60

codecov-commenter commented 1 year ago

Codecov Report

Merging #61 (1870f90) into release/3.0.0 (6cb2449) will increase coverage by 0.00%. The diff coverage is 75.00%.

@@              Coverage Diff               @@
##           release/3.0.0      #61   +/-   ##
==============================================
  Coverage          67.64%   67.65%           
==============================================
  Files                 12       12           
  Lines               3576     3580    +4     
==============================================
+ Hits                2419     2422    +3     
- Misses              1157     1158    +1     
Impacted Files Coverage Δ
safedata_validator/field.py 93.48% <75.00%> (-0.10%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more