search

ImperialCollegeLondon / sharpy

Simulation of High Aspect Ratio aeroplanes and wind turbines in Python: a nonlinear aeroelastic code
https://imperial.ac.uk/aeroelastics/sharpy
BSD 3-Clause "New" or "Revised" License
119 stars 58 forks source link

Update XBeam version to include compiler optimisation #271

Closed ben-l-p closed 7 months ago

ben-l-p commented 7 months ago

Updated XBeam to change compile flags used in GFortran. The -ftree-parallelize-loops=4 optimisation flag was found to make the beam solver take considerably longer to run than without it. The -ofast flag was added as this should increase performance in some cases with no noticeable impact on results.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ee7206f) 67.69% compared to head (5a92f77) 67.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #271 +/- ## ======================================== Coverage 67.69% 67.69% ======================================== Files 166 166 Lines 26709 26847 +138 ======================================== + Hits 18081 18175 +94 - Misses 8628 8672 +44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kccwing commented 7 months ago

I've rerun the docker tests after the new commit for continuation line - let's merge after that's all checked out! Thanks Ben for fixing this - good work on improving the runtimes for everyone!!

ben-l-p commented 7 months ago

Issue with Docker not building has been resolved. Issue was with a mamba clean statement, with the same issue found HERE. Fixing this doesn't seem so straightforward when done in Docker. For now I have removed this statement, as mamba downloads all the packages anyway during installation, cleaning will only save a bit of storage, and not time.