ImperialCollegeLondon / sharpy

Simulation of High Aspect Ratio aeroplanes and wind turbines in Python: a nonlinear aeroelastic code
https://imperial.ac.uk/aeroelastics/sharpy
BSD 3-Clause "New" or "Revised" License
119 stars 58 forks source link

A few minor bug fixes #273

Closed sduess closed 6 months ago

sduess commented 7 months ago

Hey,

Here are just a few minor bug fixes:

  1. Fixed the headers and output shapes of the force and moment matrix that are written to a file in the postprocessor aeroforcescalculator.py ( #208).
  2. There was a small bug in modalutils.py that caused not exporting 10 of the last mode shapes if rigid body motions are considered ( #208).
  3. There's a small format bug that does not cause the Jupyter Notebook for the UDP control tutorial to open (at least for my visual code) and it's also not displayed in the documents (might the caused by the same format error).
  4. Most importantly, I deleted some left-over debugging prints giving Ben headaches, although he hopefully uses the remove button himself next time (better than taking paracetamole).
  5. In one previous merge request, the indentation in the savedata.py postprocessor got confused and certain files were not outputted anymore for specific conditions. This is fixed and I updated some "remove if the file exists" commands for all output data cases, otherwise it would not overwrite previous data.

Enjoy your christmas holidays!

codecov-commenter commented 7 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5aa25e3) 67.69% compared to head (f6a01ac) 67.70%.

Files Patch % Lines
sharpy/postproc/savedata.py 52.17% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #273 +/- ## ======================================= Coverage 67.69% 67.70% ======================================= Files 166 166 Lines 26709 26709 ======================================= + Hits 18081 18082 +1 + Misses 8628 8627 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.