Scipy 1.12.0 Incompatible

ImperialCollegeLondon / sharpy

Simulation of High Aspect Ratio aeroplanes and wind turbines in Python: a nonlinear aeroelastic code

https://imperial.ac.uk/aeroelastics/sharpy

BSD 3-Clause "New" or "Revised" License

119 stars 58 forks source link

Scipy 1.12.0 Incompatible #276

Closed SJ-Innovation closed 4 months ago

SJ-Innovation commented 5 months ago

Describe the bug scipy.fftpack has been deprecated since 1.14.x, attempting to run with scipy 1.12.x results in import failure of "ifft" from scipy.

To Reproduce Clean build a Docker image runtime environment using current environment.yml which does not provide version compatibility information, attempt to run, ImportError.

Solutions Either add version compatibility information to environment.yml file, or update entire codebase to scipy 1.12.x PR for initial hotfix in progress.

kccwing commented 5 months ago

Thanks @SJ-Innovation for spotting this! We will be addressing this in our next bug fix.

ben-l-p commented 4 months ago

Issue should be fixed with the recent change to pip install HERE, which updated the code to use the new FFT library. Any "recent" version of SciPy from the last few years should work fine.