Is your feature request related to a problem? Please describe.
Off the back of the decisions in #364, we are for the moment sticking with models taking CoreConst and ModelConst objects. We can see how that plays out and have a path in #364 for an alternative approach to a single object.
Given that, we should extend the BaseModel definition so that it includes that CoreConst argument and then create a single instance vr_run to be passed off when models are initiatialised.
Describe alternatives you've considered
Some models may not use the CoreConst - although I'd expect that to get rare as we develop the contents of that class. We could simply stick with the current approach of having models create their own CoreConst instance from Config if they need it.
davidorme
commented
8 months ago
Is your feature request related to a problem? Please describe.
Off the back of the decisions in #364, we are for the moment sticking with models taking
CoreConstandModelConstobjects. We can see how that plays out and have a path in #364 for an alternative approach to a single object.Given that, we should extend the BaseModel definition so that it includes that
CoreConstargument and then create a single instancevr_runto be passed off when models are initiatialised.Describe alternatives you've considered
Some models may not use the
CoreConst- although I'd expect that to get rare as we develop the contents of that class. We could simply stick with the current approach of having models create their ownCoreConstinstance fromConfigif they need it.