Feature/use abiotic tools - Githubissues

ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.

https://virtual-ecosystem.readthedocs.io

BSD 3-Clause "New" or "Revised" License

9 stars 1 forks source link

Feature/use abiotic tools #386

Closed vgro closed 9 months ago

vgro commented 9 months ago

This PR combines a number of minor changes to link submodules:

replace constant latent_heat_vaporisation and molar_density_air in the hydrology model with values that are now actually calculated at each time step
some constants moved from HydroConsts to CoreConsts
wind_speed is now an input to the example vr_run
both models have the new BaseModel structure (please check if this is correct, I still feel like the use/import of CoreConsts isn't quite right)
all the horizontal flow was moved to daily time step

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works