ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Fixing broken tests #393

Closed davidorme closed 8 months ago

davidorme commented 8 months ago

Description

Hopefully this fixes #390.

I think the issue is that the hydrology model needs to initialise after plants, because that populates the leaf_area_index data. That isn't explicitly set in the configuration, so then I think we are getting platform specific variation in the way TopologicalSorter is returning 'tied' models, such that plants and hydrology can vary in their execution order.

More generally - this kinda thing needs to break in a much more informative way, but the variables stuff is targeted at this (#370, #388).

Type of change

Key checklist

Further checks

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.18%. Comparing base (76f1906) to head (7264214).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #393 +/- ## ======================================== Coverage 93.18% 93.18% ======================================== Files 60 60 Lines 2920 2920 ======================================== Hits 2721 2721 Misses 199 199 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidorme commented 8 months ago

Fingers crossed!