Closed davidorme closed 6 months ago
Just spotted the VR in VR run complete
.
I think we are using while
because the original conception of the model had a kind of event stack - not everything happened on a synchronised tick with a fixed set of update times. I think that is something we may want to bring back in at some point. But ultimately, although a for loop would work better with tqdm
here, I wanted to keep the changes simple.
Description
This PR adds a simple optional progress report to
ve_run
, so that something happens when the command runs and logging is being sent to file (which is likely all reasonable use cases).When
ve_run
is executed with--progress
, a user sees:Fixes #402
There are probably more elegant ways of handling the
tqdm
progress bar, buttqdm
is usually used with afor
loop rather thanwhile
. We could explicitly loop over the known number of updates at the moment, but retaining the currentwhile
timing loop is a useful implicit reminder that updates might not always be synchronised.Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks