Closed vgro closed 5 months ago
Attention: Patch coverage is 99.80769%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 94.11%. Comparing base (
25e9edf
) to head (bd073d7
).
Files | Patch % | Lines |
---|---|---|
...le_data/generation_scripts/climate_example_data.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you again for your feedback on the overall structure. I tried to implement the changes you suggested. Still outstanding/to discuss:
DataArray
and np.array
is not great but this comes from using functions in different parts of the VE where they have different requirements. It has to be some sort of compromise I guessLayerStructure
, the topsoil layer index and the number of canopy layers which updates every time step. I tentatively put it in setup and update which is obviously not great, but I would prefer to tackle this in a separate PR.
This PR adds the energy balance to the process-based
abiotic
model. I apologize for the size of the request, the processes are all very interconnected and I missed the point to stop. It should however not be too complicated (please let me know if you need smaller chunks to review). Renaming everything added to the number of files that were changed, and all abiotic files seem completely new, but it should be very easy to filter out.Here the main changes:
abiotic
modelabiotic_tools
submodulesoil_energy_balance
submoduleconductivities
submoduleenergy_balance
above ground submoduledummy_climate_data
wind_speed_ref
to example dataThere are currently a number of unresolved/not implemented processes which require further advancement in other models of the Virtual Ecosystem or potentially some changes to the vertical layer structure (see
abiotic_model
):Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks