ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Feature/calculate conductivities #406

Closed vgro closed 5 months ago

vgro commented 6 months ago

This PR adds the energy balance to the process-based abiotic model. I apologize for the size of the request, the processes are all very interconnected and I missed the point to stop. It should however not be too complicated (please let me know if you need smaller chunks to review). Renaming everything added to the number of files that were changed, and all abiotic files seem completely new, but it should be very easy to filter out.

Here the main changes:

There are currently a number of unresolved/not implemented processes which require further advancement in other models of the Virtual Ecosystem or potentially some changes to the vertical layer structure (see abiotic_model):

Type of change

Key checklist

Further checks

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 99.80769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.11%. Comparing base (25e9edf) to head (bd073d7).

Files Patch % Lines
...le_data/generation_scripts/climate_example_data.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #406 +/- ## =========================================== + Coverage 93.20% 94.11% +0.91% =========================================== Files 60 68 +8 Lines 2959 3434 +475 =========================================== + Hits 2758 3232 +474 - Misses 201 202 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vgro commented 6 months ago

Thank you again for your feedback on the overall structure. I tried to implement the changes you suggested. Still outstanding/to discuss: