np.mean error fixed - Githubissues

ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.

https://virtual-ecosystem.readthedocs.io

BSD 3-Clause "New" or "Revised" License

9 stars 1 forks source link

np.mean error fixed #414

Closed vgro closed 5 months ago

vgro commented 5 months ago

There was a small error in the hydrology model that caused ve_run to throw a warning, this is the fix.

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

davidorme commented 5 months ago

Just to check - with this PR, we:

can leave the reviewed content of feature/calculate_conductivities in develop rather then stepping through a merge feature/new_abiotic_module and then into develop.
fix the minor issue on develop.
can now close #412 as unnecessary
delete feature/new_abiotic_module as everything in that branch went into feature/calculate_conductivities and hence into develop?

vgro commented 5 months ago

Just to check - with this PR, we:

* can leave the reviewed content of `feature/calculate_conductivities` in `develop` rather then stepping through a merge `feature/new_abiotic_module` and then into `develop`.

* fix the minor issue on `develop`.

* can now close [Revert "Feature/calculate conductivities" #412](https://github.com/ImperialCollegeLondon/virtual_ecosystem/pull/412) as unnecessary

* delete `feature/new_abiotic_module` as everything in that branch went into `feature/calculate_conductivities` and hence into `develop`?

yes, that is all fine