Feature/revised wind model

ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.

BSD 3-Clause "New" or "Revised" License

9 stars 1 forks source link

This PR includes a number of fixes and improvements to the wind model:

wind tests check for different number of canopy layers
friction velocity and diabatic correction factor functions are corrected and simplified
TODOs related to hardcoded heights are fixed
many many mini bugs fixed and comments added

One outstanding big TODO is related to the use/extension of the LayerStructure to select subsets of data more easily, for example true_canopy_layers.

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.59%. Comparing base (7c55684) to head (5e1c1e2).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #418 +/- ## =========================================== + Coverage 94.52% 94.59% +0.07% =========================================== Files 69 69 Lines 3598 3648 +50 =========================================== + Hits 3401 3451 +50 Misses 197 197 ```

ImperialCollegeLondon / virtual_ecosystem