Closed vgro closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.52%. Comparing base (
13ef532
) to head (faf26e6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR changes the soil moisture unit to mm in the data object. For some calculations in the hydrology and abiotic model, it is still needed in volumetric moisture content, but I think I reduced the number of conversions. I also tidied the code based on what we have learned, but there is still a big outstanding issue with accessing indices etc.
@jacobcook1995 could you add the changes needed in the soil model to this branch please?
Fixes #345
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks