Feature/test ragged arrays

vgro commented 3 months ago

This PR adds a new dummy climate data fixture to test that the abiotic_simple model works with different numbers of canopy layers (the mechanistic abiotic model tests are not updated here). I kept the old tests for now, could be removed or merged in the future.

Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.69%. Comparing base (5621b8d) to head (2862d3d).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #424 +/- ## ======================================== Coverage 94.69% 94.69% ======================================== Files 69 69 Lines 3732 3732 ======================================== Hits 3534 3534 Misses 198 198 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vgro commented 3 months ago

LGTM (with the caveat that I don't 100% get how ragged arrays work)

Thank you for the quick review, I'll wait what David thinks before I merge because it will affect him, too :-)

ImperialCollegeLondon / virtual_ecosystem