ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Simplify the `jupyter kernelspec` setup #429

Closed davidorme closed 3 months ago

davidorme commented 3 months ago

Description

This removes the ve_python3 specific kernel for jupyter and falls back to poetry run/shell setting the jupyter kernelspec to point to the active poetry venv for the project.

The tests below and RTD all work, showing this simplification works as expected: https://virtual-ecosystem.readthedocs.io/en/427-simplify-the-jupyter-kernelspec-setup/

Closes #427

Type of change

Key checklist

Further checks

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.60%. Comparing base (0ccb1c7) to head (73686c6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #429 +/- ## ======================================== Coverage 94.60% 94.60% ======================================== Files 70 70 Lines 3744 3744 ======================================== Hits 3542 3542 Misses 202 202 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.