Feature/fixes for variables pr

ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.

https://virtual-ecosystem.readthedocs.io

BSD 3-Clause "New" or "Revised" License

8 stars 1 forks source link

Feature/fixes for variables pr #430

Closed vgro closed 3 months ago

vgro commented 3 months ago

This PR adds missing variables to the data object and updates some units in preparation for #388

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.61%. Comparing base (1132d87) to head (9edff9d).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #430 +/- ## ======================================== Coverage 94.60% 94.61% ======================================== Files 70 70 Lines 3744 3750 +6 ======================================== + Hits 3542 3548 +6 Misses 202 202 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidorme commented 3 months ago

~Should this merge into the variables branch, not develop?~

Oh no, wait. We had that discussion didn't we 😄 Have not had any ☕