434 soil temperature not returned correctly - Githubissues

ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.

https://virtual-ecosystem.readthedocs.io

BSD 3-Clause "New" or "Revised" License

8 stars 1 forks source link

434 soil temperature not returned correctly #435

Closed vgro closed 2 months ago

vgro commented 3 months ago

The soil layer heights were missing in the dummy data set with variable layer heights. Therefore, all soil temperatures were nan.

Fixes #434

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works