ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Regularise `animals.animal_model.py` file name #438

Closed davidorme closed 2 months ago

davidorme commented 2 months ago

Describe the bug

There's a minor issue with the AnimalModel setup. All the other models use virtual_ecosystem.models.name.name_model.py for their model file, and we're relying on that name_model pattern for variable discovery. The animals model has animals.animal_model.py, which breaks the pattern.

Rather than create exceptions in model discovery, we need to change to animals.animals_model.py or animal.animal_model.py thoughout and @TaranRallings prefers the latter.