ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

LayerStructure updates for abiotic_simple #448

Closed davidorme closed 2 months ago

davidorme commented 2 months ago

Description

This PR introduces changes to make the abiotic_simple model work with the new LayerStructure in #421.

@vgro - if you can have a look at the changes to see if anything looks mad (but the tests pass, so hopefully not) then I can merge it down into #421.

The main changes to the actual code are passing LayerStructure down the chain rather than layer_roles and then using that functionality.

Fixes #446

Type of change

Key checklist

Further checks

vgro commented 2 months ago

@davidorme thanks for your help with this, it looks really good, a few minor tweaks. I'll finish the hydrology stuff that I started yesterday and then I'll make the changes here, I'll let you know when I need you to review again.

davidorme commented 2 months ago

The abiotic_simple tests all pass locally, which is the point of this subbranch, so merging it down into #421.