ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.

https://virtual-ecosystem.readthedocs.io

BSD 3-Clause "New" or "Revised" License

8 stars 1 forks source link

Initial draft of abiotic model changes for new LayerStructure #449

Closed davidorme closed 2 months ago

davidorme commented 2 months ago

Description

These are the updates needed to get the abiotic model working with #421. This is very WIP - I haven't merged in #421 yet, but these are the current changes. Many tests pass but not all.

The initial push was made with --no-verify to isolate the model and test changes in a single commit, rather than blurring them with the downstream changes.

Fixes #447 (issue)

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist

[ ] Make sure you've run the pre-commit checks: $ pre-commit run -a
[ ] All tests pass: $ poetry run pytest

Further checks

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

davidorme commented 2 months ago

This branch now passes all abiotic models tests except the one that has been skipped.

@vgro has looked over the suggested changes and thinks they all look sane and we both agree that - given the abiotic model is still in early development - it makes sense for now simply to update the model code to the new LayerStructure to make it easier to pick up in the future and then move on. So I'm going to merge this down to #441 and iron out the remaining top level (CLI, ve_run) implementation issues there.