ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Adding a microbial necromass pool #477

Closed jacobcook1995 closed 3 months ago

jacobcook1995 commented 3 months ago

Description

This pull request extends the soil carbon model to include a pool for microbial necromass (dead cells, denatured enzymes, etc). As part of this I have changed some of the previous flows between carbon pools.

I've also tried to break the main function used by the soil model integration up a bit (see #344). This is far from complete, but hopefully it's a bit more readable now.

I haven't added any documentation changes to the PR as I'm planning to overhaul the soil model documentation in the near future anyway.

Type of change

Key checklist

Further checks

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 79.22078% with 16 lines in your changes missing coverage. Please review.

Project coverage is 94.95%. Comparing base (92de3ee) to head (d8afa00).

Files Patch % Lines
...ample_data/generation_scripts/soil_example_data.py 0.00% 10 Missing :warning:
...ple_data/generation_scripts/litter_example_data.py 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #477 +/- ## =========================================== - Coverage 94.95% 94.95% -0.01% =========================================== Files 70 70 Lines 3869 3886 +17 =========================================== + Hits 3674 3690 +16 - Misses 195 196 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.