ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Abiotic simple - conservation of energy with bounds setting #483

Open vgro opened 3 months ago

vgro commented 3 months ago

At the moment, the abiotic_simple model sets values that fall outside the range of expected values to the upper or lower bound value. This is true for all updated variables; the bounds are defined in the abiotic_simple/constants.py. The problem is that this approach does not conserve energy or matter.

I currently do not have a solution ready. For now, we should produce a warning or error message.