ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Direct input from plant model to the litter model #509

Closed jacobcook1995 closed 3 months ago

jacobcook1995 commented 3 months ago

Description

This PR changes the litter model to receive input from the plant model. This input then gets split between pools based on its lignin content and C:N ratio. Science wise it is relatively straightforward, but there's a couple of things to note from a code perspective:

  1. @davidorme this PR alters plant model code, let me know if you are happy with the general structure
  2. This PR adds 11 new variables to the data object, this has lead to some fairly huge functions signatures, if anyone has any suggestions for how best to handle this please let me know.

Type of change

Key checklist

Further checks

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.93%. Comparing base (fb253a5) to head (b8f44a4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #509 +/- ## =========================================== + Coverage 94.90% 94.93% +0.03% =========================================== Files 71 73 +2 Lines 4020 4050 +30 =========================================== + Hits 3815 3845 +30 Misses 205 205 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.