ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Review the implementation section of the docs #516

Closed davidorme closed 2 months ago

davidorme commented 2 months ago

Description

This PR improves the implementation section of the documents. The docs for the PR are being built here:

https://virtual-ecosystem.readthedocs.io/en/514-review-the-implementation-section-of-the-docs/virtual_ecosystem/implementation/implementation.html

Broadly:

This PR also fiddles with sphinx:

Fixes #514

Type of change

Key checklist

Further checks

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.93%. Comparing base (62ebb70) to head (ae99383).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #516 +/- ## ======================================== Coverage 94.93% 94.93% ======================================== Files 73 73 Lines 4050 4050 ======================================== Hits 3845 3845 Misses 205 205 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidorme commented 2 months ago

@dalonsoa and @jacobcook1995

I realised I was starting to run away with a grand documentation PR so I'm giving myself a stern talking to and stopping. Could you have another quick look and see if anything is wildly bad? The documentation stuff is quite 'dynamic' right now, so I think we'll likely have a tidy up phase once all of this has settled down.

davidorme commented 2 months ago

@dalonsoa Yup - we've got a lot of movement and it seems better to keep everything up to date in develop and use small PRs rather than spinning off into deep parallel PRs!