ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

519 review abiotic simple and hydrology docstrings to match updated documentation #521

Closed vgro closed 3 months ago

vgro commented 3 months ago

This PR updates the docstrings for the abiotic_simple and hydrology models. Nothing major, only a few bits that were outdated or inconsistent.

Also, I (was trying to) get rid of the variables that are initialized but not needed in the hydrology model. This led to an old problem of random model order on Windows which caused some tests to fail. The change needs to be postponed until the variables system is up and running, see #522

Fixes #519

Type of change

Key checklist

Further checks

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.93%. Comparing base (bfe28c2) to head (3c49c6c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #521 +/- ## =========================================== - Coverage 94.93% 94.93% -0.01% =========================================== Files 73 73 Lines 4050 4048 -2 =========================================== - Hits 3845 3843 -2 Misses 205 205 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.