ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Move setup step to init in `Abiotic` and `AbioticSimple` models #524

Closed dalonsoa closed 2 weeks ago

dalonsoa commented 2 months ago

Description

It was done already for the Hydrology model but I forgot to do the same for the other two. The main changes have more to do with fixing the tests than the actual change in the code.

Fixes # N/A

Type of change

Key checklist

Further checks

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.98%. Comparing base (7ce59b2) to head (997f395).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #524 +/- ## ======================================== Coverage 94.97% 94.98% ======================================== Files 74 74 Lines 4141 4145 +4 ======================================== + Hits 3933 3937 +4 Misses 208 208 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidorme commented 2 months ago

@TaranRallings - The animal model also uses a setup method, which is currently also called from within __init__, so runs twice.