ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Animal - Feature/multi grid no community #538

Open TaranRallings opened 1 month ago

TaranRallings commented 1 month ago

Description

@davidorme suggested that multi-grid occupancy might work better without the AnimalCommunity class. I have spent some time refactoring the code to see if this is the case. The current version is not finished and probably has a number of errors (many tests are now broken) but this gives a strong sense of the resulting format.

Pros: I got to ditch a lot of hacky nonsense that I was doing to avoid circular imports and related issues. Cons: I am aesthetically vexed by having all of this content crammed into AnimalModel.

So it does seem like this format is probably better.

I would appreciate some feedback on this format for multi-grid and the future of the Animal Model in comparison to my previous multi-grid attempt here #530.

Fixes # (issue)

Type of change

Key checklist

Further checks