ImperialCollegeLondon / virtual_ecosystem

This repository is the home for the codebase for the Virtual Ecosystem project.
https://virtual-ecosystem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Add phosphorus to litter model #539

Closed jacobcook1995 closed 5 days ago

jacobcook1995 commented 2 weeks ago

Description

This pull requests adds tracking of litter phosphorus concentrations. This follows an identical structure to the nitrogen case. I did consider trying to make a generic functions rather than duplicating functions, but it didn't feel worth the effort as we have no current plans to add further nutrients (e.g. Potassium).

As there weren't any structural changes I didn't split this up into separate PRs, hopefully it is a manageable size as a single PR.

Fixes #512

Type of change

Key checklist

Further checks

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.95%. Comparing base (ca04b51) to head (76f76f9).

Files with missing lines Patch % Lines
...ple_data/generation_scripts/litter_example_data.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #539 +/- ## =========================================== - Coverage 94.98% 94.95% -0.03% =========================================== Files 74 74 Lines 4145 4186 +41 =========================================== + Hits 3937 3975 +38 - Misses 208 211 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.