search

ImperialSquid / zotero-zotts

A Zotero plugin adding text to speech (TTS) functionality to various screens
GNU Affero General Public License v3.0
86 stars 1 forks source link

Remove parenthesis during speech #93

Closed flightmansam closed 2 months ago

flightmansam commented 2 months ago

since citations are a distraction to me

ImperialSquid commented 2 months ago

Thanks again for the interest in contributing and for the PRs!

For this one specifically, I think it's overshadowed by a larger feature I was working on (if you check out the substitutions feature in docs/ROADMAP.md, it's that) (sorry the repo isn't up to date with that code, internet issues)

This way the user can specifying their own patterns for cleaning up the spoken text, there would be a text box in the preferences that allows them to give pattern-replacement pairs on each line, with patterns allowed to be simple string replacements or full regex patterns.

For example:

# fix notation pronunciation
">":"greater than"
# remove email addresses
/\S+?@\S*/:""

That said, since requiring users learn regex just to access the more advanced uses of the feature might be a bit of a steep ask, I really like the idea of having specific toggle-able replacements built in, like the citations one you described or the email addresses example above.

So if that makes sense to you and you're ok with it, I'll probably reject this PR in favour of that larger feature, but I'll start working on adding specific built in substitutions based on this idea.

Let me know what you think!

flightmansam commented 2 months ago

Yeah I suppose it could go either way! I get the feeling that most people who would be using this addon for Zot would probably be nerdy enough to be able to edit a little chain of regexs. But maybe the ulitmate ux is somthing that can have toggles and that shows you side by side what exactly that injects into the replacements. Happy for you to close the PR, just wanted to leave it here as a trail that I have some ideas forming. :)