search

ImplicitSaber / Forkcart

More interesting minecart tracks - Forked and updated by ImplicitSaber
MIT License
2 stars 1 forks source link

Player movement broken on 1.20.1 Sinytra Connector environment #2

Closed NoaHimesaka1873 closed 1 month ago

NoaHimesaka1873 commented 1 month ago

Player movement will not follow camera movement on 1.20.1 (Neo)Forge + Sinytra Connector environment. Debug log: https://mclo.gs/6DPOMF1

ImplicitSaber commented 1 month ago

It's probably because of how (Neo)Forge works much differently than Fabric. To make cart camera rotation work in 1.20.1, I had to redirect multiple MatrixStack multiplications in the GameRenderer to make them match newer versions. It would be quite hard to make this work on Sinytra Connector on old versions, but that's not to say it's impossible. It may happen in the future.

ImplicitSaber commented 1 month ago

Upon further examination, it seems that the problem is already fixed on NeoForge. I'll just remove my hacky Mixin fix if Connector is detected. Edit: that's on 1.21. 1.20.1 did not fix the problem and camera rotation on tracks will be disabled on that version if using Connector

ImplicitSaber commented 1 month ago

Should now be fixed in 1.20.1-1.1.0-fix2