search

ImpressCMS / impresscms

A multilingual, extensible, community oriented CMS developed in PHP
https://www.impresscms.org
Other
28 stars 35 forks source link

Forms should not be hard-coded to generate html tables #1237

Open fiammybe opened 2 years ago

fiammybe commented 2 years ago

When building the bulma theme, I was trying to generate a form following the bulma way of working, by adapting the system_common_form.html and system_default_form.html templates. Nothing happened. Looking into the icms library code, the render procedures of the icms_form_Theme and the icms_form_Simple classes simply generate hardcoded HTML tables with the element data. These procedures should be updated to make use of the Smarty templates that are available.

MekDrop commented 2 years ago

If you use SASS compiler for CSS theme there is workaround -> @extend keyword.

But yea having such option in core would be great. And not only in 1.5.x but also in 2.0.x

skenow commented 2 years ago

See #85

fiammybe commented 2 years ago

Gosh, this goes back a long time. Let's see if I can get this darn template working in the next few days. The thing is that a template exists in the system module, it just isn't used.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 5 days with no activity.

fiammybe commented 2 years ago

I have been looking into this on-and-off between other more pressing tasks. I found out that most of the forms templates that are available simply are not used by the core :-(

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.