search

ImpressCMS / impresscms

A multilingual, extensible, community oriented CMS developed in PHP
https://www.impresscms.org
Other
27 stars 35 forks source link

use of removed $icmsModule througout the core #1538

Open fiammybe opened 7 months ago

fiammybe commented 7 months ago

the global variable $icmsModule is no longer available, and should be replaced by icms::$module. But I still see lots of places in the core where that variable is used.

fiammybe commented 7 months ago

It's not so easy I fear. The $icmsModule variable is sometimes used internally, so it's not as easy as replacing them all with icms::$module :-(

skenow commented 7 months ago

Yes, I have found places where it is defined and used - got to review them 1 by 1

skenow commented 7 months ago

And I think I got quite a few of them changed while working on the PHP7/8 compliance

skenow commented 7 months ago

I stand corrected - I just did a search and there are over 150 occurrences still left

fiammybe commented 2 months ago

I tried migrating the ImpressCMS site to 2.0 RC2 and it bombed on me :-( Most of the issues will be the use of $icmsModule in the modules used on the site, but I'm going through the files to see if I can get it working on the beta site. After that, I can re-try the migration from a fresh dump. This is blocking for the 2.0 release I'm afraid.