search

ImpressCMS / impresscms

A multilingual, extensible, community oriented CMS developed in PHP
https://www.impresscms.org
Other
27 stars 35 forks source link

Remove check for PHP7 once Protector is PHP7-compatible #423

Closed todo[bot] closed 5 years ago

todo[bot] commented 5 years ago

https://github.com/ImpressCMS/impresscms/blob/d45db48b6cdbe93a8904593febb8441ec6cc0231/htdocs/install/page_modulesinstall.php#L69-L74

This issue was generated by todo based on a TODO comment in d45db48b6cdbe93a8904593febb8441ec6cc0231 when #419 was merged. cc @fiammybe.
fiammybe commented 5 years ago

depends on #496 and #482

skenow commented 5 years ago

My latest commits have addressed #496. The issue in #482 was a syntax error and should be working as intended at this point. Pull request #492 does contain all these updates and needs review.

skenow commented 5 years ago

I missed it - #492 has been merged into the branch and the check for the PHP version was removed - the todo was not.

I need to pay better attention ;-)