search

ImpressCMS / impresscms

A multilingual, extensible, community oriented CMS developed in PHP
https://www.impresscms.org
Other
28 stars 35 forks source link

using mysql_connect in installation - unsupported since php7 #79

Closed fiammybe closed 6 years ago

fiammybe commented 7 years ago

Even though I'm using the PDO connection, the installer still tries to connect to mysql with an unsupported function. When I do the setup on PHP 7.0.9 I get the following :

Fatal error: Uncaught Error: Call to undefined function mysql_connect() in C:\xampp70\htdocs\icms1310\install\page_dbconnection.php:50 Stack trace: #0 {main} thrown in C:\xampp70\htdocs\icms1310\install\page_dbconnection.php on line 50

in file icms1310/install/page_dbconnection.php

fiammybe commented 7 years ago

okay, like @skenow already mentioned, this is not a simple fix. PHP7 support is a requirement for 2.0 (as it will be the only version still supported by the time we release), so I propose to rewrite this part and make it simpler : only PDO.

MekDrop commented 7 years ago

I already have half needed code in my DB rewrite branch (mongodb and pdo) :) I just need somehow just to finish.

fiammybe commented 7 years ago

Great news, I'll have a look at what you did there

Op do 26 jan. 2017 09:18 schreef Raimondas Rimkevičius < notifications@github.com>:

I already have half needed code in my DB rewrite branch (mongodb and pdo) :) I just need somehow just to finish.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ImpressCMS/impresscms/issues/79#issuecomment-275330691, or mute the thread https://github.com/notifications/unsubscribe-auth/ADkFcrzrWcqaKxE492or9E6z669QGH-Bks5rWFa-gaJpZM4LaXnN .

MekDrop commented 7 years ago

I think you should wait a bit. At current stage my code is messed up ;( I need to find some time to fix it.