search

ImpressModules / imblogging

A basic blogging module for ImpressCMS
Other
0 stars 2 forks source link

Division by 0 on front page #6

Closed fiammybe closed 4 months ago

fiammybe commented 4 months ago

In a new installation on impressCMS 2b1, on PHP8.0, I get a division by zero error in the icms_view_PageNav class. Commenting out line 84 in index.php makes it go away.

skenow commented 4 months ago

In index.php of imblogging? Line 84 is a blank line in the master branch

Maybe line 106 after the last merge for meta information? $pagenav = new icms_view_PageNav($posts_count, icms::$module->config['posts_limit'], $clean_start, 'start', $extr_arg);

skenow commented 4 months ago

What do you have for Posts Limit in the preferences for the module? The default is 5

fiammybe commented 4 months ago

Correct, it's line 106 now. I'll reinstall with the latest code, my personal branch looks to be outdated even though my IDE says not.

skenow commented 4 months ago

I haven't been able to reproduce this - even setting posts_limit to 0 or blank

fiammybe commented 4 months ago

The update to 1.2 RC fixes this problem. Closing.