Imprex-Development / orebfuscator

Orebfuscator - High-Performance Anti X-Ray plugin
https://modrinth.com/plugin/orebfuscator
GNU General Public License v3.0
126 stars 25 forks source link

Odd bug #383

Open SavageTheUnicorn opened 1 month ago

SavageTheUnicorn commented 1 month ago

Description

I've been using orebfuscator for a while and it works flawlessly for 99% of my players. Apparently not 1% though haha. It DOES work, and obfuscate ores and blocks but it's a bit wonky to say the least. A player sees an ore exposed to air and breaks it but it updates all blocks nearby back to their original. Video attached to show the issue.

https://github.com/user-attachments/assets/7df1f28f-866e-4e64-982f-54f4f3df3943

Reproduction Steps

I have not been able to reproduce this personally. The user uses vanilla minecraft, our server does have viaversion though.

Expected Behaviour

Ores show normally(maybe see a fake ore occasionally on bad wifi)

Orebfuscator Dump

https://gist.github.com/SavageTheUnicorn/07bc14e6d778adb197a6a7bf1bff9420

Extra Details

No response

Ingrim4 commented 1 month ago

That's a well known problem with the disk cache because each cache entry only contains a hash of the current chunk and not the neighboring chunks. Meaning if you mine out a chunk perfectly inside the chunk border (16x16) and than rejoin the server that the neighboring chunks will still think they are up to date and serve the invalid cache entry. We looked at ways to mitigate that but weren't happy with the performance degradation so we didn't ship it.

You could disable disk cache (memory cache should be fine and can stay enabled) to mitigate this if it bothers you.