search

ImpromptuNinjas / UltralightSharp

Multi-platform .NET bindings to the Ultralight project.
Other
129 stars 17 forks source link

Safe.IndexBuffer.Data should be Span<uint> instead of Span<float> #10

Open RawRCoder opened 3 years ago

RawRCoder commented 3 years ago

https://github.com/ImpromptuNinjas/UltralightSharp/blob/e3b7e82f687c81d8ba22490641e1eef6134b2488/UltralightSharp/DataStructs/IndexBuffer.cs#L41

I've never heard of float index buffers, and also they use DXGI_FORMAT_R32_UINT in dx12 demo app, so float seams to make no sense here.

PS: Perhaps Data property (here and in VertexBuffer as well) should better be ReadOnlySpan<T> instead of Span<T>?