ImpulseAdventure / GUIslice-Builder

Cross-platform drag & drop GUI builder for GUIslice
Other
168 stars 35 forks source link

Folder loop creation when saving to new location #215

Closed raomin closed 1 year ago

raomin commented 1 year ago

Describe the bug I had issues when saving to a custom location (I'll fill another issue for this), so I tried and successfully saved in the default Documents\Arduino folder. Then I wanted a better location for my files, so I created a folder named guislide, opened it and clicked the Select folder button in the UI. The program hanged and started to create sub copies of all the folders before guislide from the Arduino folder, recursively... I killed it before it went too far...

To Reproduce Steps to reproduce the behavior:

  1. Save as, select default location (Arduino).
  2. Reopen save as, create a new folder eg guislice, open the empty folder and click Select Folder.

Expected behavior New project files are create in the new folder.

Screenshots image

Version

Pconti31 commented 1 year ago

@raomin First I have no question there is a bug and a serious one at that. However I just tried your steps and (many times) and I can't reproduce the issue.

Can you zip the project you first did a saveas, and list exactly the steps and names you used?. No chance you have any links inside your project folder? Any chance your saveas project isn't stored in the path you think it is?

I notice in your screen shot arduino.ino and arduiono_GSLC.h (weird naming) in a top level folder with many folders under it Its a design point to copy all folders inside a given project folder so if you tried to saveas ardunio.ino it would copy everything under it. Project folders are supposed to be self contained.

If after you zip up your first project (I don't need to compile or run it) and I follow your more detailed steps everything still works for me I can post a debugging version of the Builder for you to try that will log everything to GUIsliceBuilder/logs/builder.log.
You can then post that file for me so can see what is going on. I'll limit the copying of files to say 20 to avoid looping. Paul--

Pconti31 commented 1 year ago

@raomin Since you haven't answered I'll assume you tried to Save As a project with many folders under it.

To save users from similar problems I have made release 17b14 which will now only go one folder deep during a Save As . Furthermore, only the folders inside a project folder named include, src, res, and test will be copied. Any other folders present inside a project folder will be ignored.

Paul--