search

ImranR98 / Obtainium

Get Android app updates straight from the source.
https://obtainium.imranr.dev
GNU General Public License v3.0
7.25k stars 161 forks source link

Please add Support for App-Package Name Configuration #1087

Closed STAINCABLER closed 10 months ago

STAINCABLER commented 10 months ago

Some apps, that I want to install from GitHub, get in Obtainium a different package name than it is. For example, in Obtainum the package name is listed as app.package.githubuser, but on my phone, after installation, the package name is com.appname.app. Unfortunately, I can't get updates for these apps via Obtainium, because the package names don't match :/

My suggestion would be that you either try to intercept the package name during installation or that you can change it in the source configuration.

Thank you for your great work with Obtainium and greetings.

ImranR98 commented 10 months ago

Could you give me an example of an app where this happens? I don't see how it could happen given that we extract app IDs directly from the APK or from sources where the ID is guaranteed to match. The only situation where this could happen is if we are trying to extract the app ID from a github repo and aren't doing so correctly.

ImranR98 commented 10 months ago

In that last case, you can disable the option that says "infer App ID from source code".

STAINCABLER commented 10 months ago

Hi, I tried adding the apps with the "infer App ID from source code" option disabled, unfortunately, it didn't change anything in terms of the app package name. Regarding your question about examples of apps, I have attached pictures and a text file with the correct package names.

real-app-package-names.txt

App-1

App-1 2 App-1 1

App-2

App-2 1 App-2 2

kinghat commented 10 months ago

another example: https://github.com/AgoraDesk-LocalMonero/agoradesk-app-foss/releases/tag/v1.1.14, when you have the repo added and i have a filter apk regex of: co.localmonero.app-foss_ for specifically trying to get: https://github.com/AgoraDesk-LocalMonero/agoradesk-app-foss/releases/download/v1.1.14/co.localmonero.app-foss_110.apk it adds the repo but says i have none installed:

image

and the locally installed app id:

image

ImranR98 commented 10 months ago

That's because there are 2 different IDs depending on which APK you pick. From the OS point of view those are 2 separatr apps - you can decide which one you want and only pick that apk.

ImranR98 commented 10 months ago

Please make sure the APK variant you select when adding the app is the one you actually want.

kinghat commented 10 months ago

Please make sure the APK variant you select when adding the app is the one you actually want.

im not sure what you mean. isnt that what im doing by setting the apk regex of co.localmonero.app-foss_? theres only one that matches that in the release assets.

ImranR98 commented 10 months ago

You have to do it when adding the app for the first time because that's when the id gets set.

kinghat commented 10 months ago

You have to do it when adding the app for the first time because that's when the id gets set.

i removed the app in obtainium and started over by adding the repo again, used the same apk regex as before, and turned off the determine the app id from source option and i think that worked.

ImranR98 commented 10 months ago

Closing - expected behaviour.