Obtainium can't work with git tags.

ImranR98 / Obtainium

Get Android app updates straight from the source.

https://obtainium.imranr.dev

GNU General Public License v3.0

7.27k stars 161 forks source link

Obtainium can't work with git tags. #1095

Closed shellheim closed 10 months ago

shellheim commented 10 months ago

Describe the bug LibreTube is a piped client for android. It's latest release 'tag' is v0.20.0 but on the releases page the highest version seems to be v0.19.0. Because of this (probably) Obtainium doesn't update to v0.20.0 and thinks v0.19.0 is the latest version.

To Reproduce

Install LibreTube through obtainium.
Confirm the latest tag on LibreTube's repo (v0.20.0)
Check the latest version installed by obtainium.

Screenshots and Logs

Latest entry on /releases page of LibreTube.

Latest entry on the /tag page of LibreTube.

Latest release installed by obtainium.

Hvyb

Please complete the following information:

Device: Is it really necessary?
OS: Android 8.1
Obtainium Version: v0.14.32-beta Additional context Is this because obtainium only looks at /releases not at /releases/tags/v.x.y when the source is gitub? Does this mean apps have to make a 'proper' release on github for obtainium to detect it?

ImranR98 commented 10 months ago

Yes, you need to have an actual release with APKs attached. If you want to use tags, you'll have to enable track only mode and that would allow you to get update notifications without actually being able to download or install anything.

shellheim commented 10 months ago

Thanks!

alexwaibel commented 10 months ago

This actually is an issue with GitHub as pointed out in the linked issue.

The releases URL doesn't show the latest release https://github.com/libre-tube/LibreTube/releases

But this URL does https://github.com/libre-tube/LibreTube/releases/latest

Maybe best to use the latter for checking for updates in obtanium?

shellheim commented 10 months ago

Yeah I did see that. Unfortunately using that url doesn't work either as it seems that obtainium defaults to https://github.com/user/project if that's present in the url. Also according to Imran obtainum only works when it's a proper release.

shellheim commented 10 months ago

A temporary fix would be to switch to the f-droid repo for the app, but the main reason I switched to obtainium was because of f-droid's slow update cycle.

ImranR98 commented 10 months ago

You could try the 'verify latest tag' option to see if that helps.

shellheim commented 10 months ago

Yeah that was on but it still doesn't seem to work.

DarkCrypt commented 10 months ago

I had this same issue with LibreTube v0.20.0. Updating to v0.20.1 went flawless.

If you go and look, v0.20.0 never hit the releases page but was in the tags. V0.20.1 is on the releases page. Definitely a GitHub issue.

Same issue going on with URL-Radio releases. V12.8 is in the tags but not on the releases page. Now I assume when v12.9 is released, this will straighten out this issue too... ? Guess we'll see.