search

ImranR98 / Obtainium

Get Android app updates straight from the source.
https://obtainium.imranr.dev
GNU General Public License v3.0
7.4k stars 164 forks source link

Asset is downloaded with incorrect file format #1581

Closed xcpn closed 4 months ago

xcpn commented 5 months ago

Describe the bug

When selecting asset to download in ZIP format, the asset is downloaded in APK format.

To Reproduce

  1. Add and save GitHub source: https://github.com/alexbakker/aegis-simple-icons
  2. After added, tap on 'Download release asset'
  3. Select 'aegis-simple-icons-v154.zip'
  4. Tap 'continue'

The asset is now downloaded as 'aegis-simple-icons-v154.apk' instead of '.zip', even though explicitly selected desired file format.

Please complete the following information:

xcpn commented 5 months ago

@ImranR98 I just realized that there's another problem with this bug.

If you choose aegis-simple-icons-v154.zip, it will download as aegis-simple-icons-v154.apk.

If you choose 154.zip, it will download correctly as 154.zip.

The new problem is that downloading either file, the downloaded file will be broken and won't work (it will throw an error when importing the ZIP file via Aegis settings).

Downloading it manually from GitHub it works as expected.

ImranR98 commented 4 months ago

https://github.com/ImranR98/Obtainium/releases/tag/v1.1.7