default 3rd party app icon not visible in dark mode

ImranR98 / Obtainium

Get Android app updates straight from the source.

https://obtainium.imranr.dev

GNU General Public License v3.0

5.79k stars 137 forks source link

default 3rd party app icon not visible in dark mode #1637

Closed grrrrr closed 1 month ago

grrrrr commented 1 month ago

Describe the bug

When in dark mode, if an app added to obtanium does not yet have an app icon, the default icon is very hard to view (purple on black).

If the theme for obtanium is light the default icon is more visible.

Screenshots and Logs

icon2

Please complete the following information:

Device: Pixel 7a
OS: GrapheneOS
Obtainium Version: 1.1.9

ImranR98 commented 1 month ago

Improved the contrast to make it more consistent: https://github.com/ImranR98/Obtainium/releases/tag/v1.1.10

grrrrr commented 1 month ago

Thanks @ImranR98 did the icon get included in that push or was it a code change only? It still looks similar to what it was

ImranR98 commented 1 month ago

The change might not be noticeable without a side by side comparison - I only increased the opacity by around 10%. It's a subjective thing but I don't want the placeholder icon to stand out too much.

grrrrr commented 1 month ago

ok, makes sense.