search

ImranR98 / Obtainium

Get Android app updates straight from the source.
https://obtainium.imranr.dev
GNU General Public License v3.0
8.1k stars 176 forks source link

Remove Signal Source #1928

Closed Hamster45105 closed 2 weeks ago

Hamster45105 commented 3 weeks ago

Describe the feature

Seeing as Signal has now started providing releases with APKs on their GitHub repo it would probably be a good idea to remove the Signal source-specific source. I've noticed the APK on the website often gets out of date with the Google Play store, so GitHub seems like a better choice now anyway.

Additional context

People who already have the Signal source added would need their configs automatically converted to the HTML/GitHub source.

DwainZwerg commented 3 weeks ago

I am against removing Signal as a source. There are several reasons for this:

  1. the latest stable version of Signal is (according to the Google Play Store) 7.20.2 (which https://signal.org/android/apk/ offers). In the GitHub repo, the oldest version is already 7.21.4 (a beta version), which, however, is not tagged as a pre-release (as well as the latest version isn't tagged as pre-release).
  2. not everyone wants to retrieve apps from GitHub. Some people may have installed Obtainium just to install apps directly from the vendor website and/or from GitLab and/or from Forgejo (Codeberg). If they were now deprived of this option, they would rightly complain.
  3. ...

Instead, I am in favor of a dialog appearing when it is detected that the signal source is being used. It should point out that Signal can now also be retrieved from GitHub and offer two buttons:

git70 commented 3 weeks ago

@DwainZwerg In my opinion (if I can vote here ;) ) this is a great idea!

Hamster45105 commented 3 weeks ago

not everyone wants to retrieve apps from GitHub. Some people may have installed Obtainium just to install apps directly from the vendor website and/or from GitLab and/or from Forgejo (Codeberg). If they were now deprived of this option, they would rightly complain.

Yeah I agree, I don't think it should be converted to the GitHub source, it should be converted to the HTML source with possibly the option to use the GitHub one instead. People using the Signal source right now wouldn't notice a difference - their config should just automatically be converted to the HTML source. For those that want to add it in the future, they would go to the config website, just like all the other apps.

I do not see why Signal (or any other of the app-specific sources for that matter) deserve their own source (unless getting updates via that app is not possible with the HTML source), and with the introduction of GitHub releases it seems like an ideal time to remove it.

the latest stable version of Signal is (according to the Google Play Store) 7.20.2 (which signal.org/android/apk offers). In the GitHub repo, the oldest version is already 7.21.4 (a beta version), which, however, is not tagged as a pre-release (as well as the latest version isn't tagged as pre-release).

While at the moment the website and Google Play Store are in sync, I often notice that the website version is behind Google Play, meaning most of the time I get updates there before Obtainium.

DwainZwerg commented 3 weeks ago

If there is a working configuration for Signal/WhatsApp/Telegram/VLC that can be retrieved from the same page using the general HTML source, the configuration should always be adapted to simplify the maintainability of the Obtainium source code.

Hamster45105 commented 2 weeks ago

Yes here it is.

Hamster45105 commented 2 weeks ago

Here are the other app-specific sources that could be removed in favour of HTML:

WhatsApp

VLC

Telegram (Doesn't support version extraction unlike the current Telegram source)

ImranR98 commented 2 weeks ago

@Hamster45105 your VLC source would be less reliable due to #715 - VLC downloads are mirrored, and the mirrors available at any given time can change. The current VLC source automatically picks a mirror link at download time, instead of at update checking time (https://github.com/ImranR98/Obtainium/blob/main/lib/app_sources/vlc.dart#L82). Using your HTML-based config, if a user receives an update notification but does not immediately install it, the link may be expired (mirror may be down) by the time they actually try installing it (if they don't pull to refresh or open the app detail page to grab a newer link).

There is a similar issue for WhatsApp: https://github.com/ImranR98/Obtainium/issues/357#issuecomment-1751770284

Your Signal source looks good though. We can definitely get rid of the dedicated Signal source and automatically switch existing entries to your config.

May as well keep Telegram since it works and we can't get the real version number through the HTML source.

Hamster45105 commented 2 weeks ago

Sounds good. Probably for another issue, but would it be possible to add an additional option likeRefresh on download that would automatically refresh the app when you click the update button?

ImranR98 commented 2 weeks ago

Removed Signal: https://github.com/ImranR98/Obtainium/releases/tag/v1.1.29

@Hamster45105 yes probably should be a separate issue.