search

ImranR98 / Obtainium

Get Android app updates straight from the source.
https://obtainium.imranr.dev
GNU General Public License v3.0
7.83k stars 173 forks source link

Allow Github OAUTH to increase rate limit/s #35

Closed Joshndroid closed 2 years ago

Joshndroid commented 2 years ago

As mentioned in the other issues, GitHub has a rate limit.

It would be cool for those of us with a GitHub account to OAUTH login (as i assume you dont want to handle/parse our GitHub login details) to increase our rate limit.

This obviously isnt going to help the other accounts such as gitlab, etc however from my experience the vast majority of my apps are served through GitHub.

ph00lt0 commented 2 years ago

Yeah or just use API keys if that is any easier

ImranR98 commented 2 years ago

Added in the latest release (Personal Access Tokens, not OAuth): https://github.com/ImranR98/Obtainium/releases/tag/v0.5.0-beta

Joshndroid commented 2 years ago

Hey @ImranR98. Thanks for the sweet update, can we get a run down of what permissions check boxes we can use to to get a PAT that is sufficient but not so permissive so as to leave us vulnerable?

ImranR98 commented 2 years ago

None of them. All the data accessed is public already, the token only increases your rate limit.

Joshndroid commented 2 years ago

perfect. thanks

ph00lt0 commented 2 years ago

I found the field in the app now. (i know it's beta and all) but the field is not super straightforward. Github credentials?

ImranR98 commented 2 years ago

I found the field in the app now. (i know it's beta and all) but the field is not super straightforward. Github credentials?

Updated with clearer messaging and a link to GitHub for more info.

S7venLights commented 2 years ago

I've set this up now too, it's great, gave me an idea too, since a token can allow Obtanium to 'read user' and 'notifications' you could maybe use these permissions to get app lists easier and get notifications of repo releases. When you follow an app on Github, you can set it to only notify you of releases by using the follow buttons drop down menu and custom settings. Just a thought for future if you need it. For now it seems to work.

ph00lt0 commented 2 years ago

Not really a fan of that idea @S7venLights this would require you to also get the notifications on Github. The app should handle this for the user and don't notify you on other places. In an ideal scenario the apps all auto update without any user interaction. This makes it much easier to user for non techies.

S7venLights commented 2 years ago

Yeah it's just an idea for an alternative option if needed. It could for example ensure notifications of updates if there are rate limit or other issues in future.